sdmx: add minimal ISTAT endpoint fallback#76
Merged
Conversation
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 918732d3da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
FindingsMedium
Low
Open questions
VerdictTip Verdict: Il PR è solido, ben testato e risponde esattamente al problema di affidabilità sollevato in #75 senza sovradimensionare la soluzione tecnica. I test mock coprono i casi limite (timeout, 5xx, 404) in modo efficace. Review effettuata seguendo la skill canonica |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75.
Contesto
Il primo pilot reale SDMX su
istat-housing-crowdingha mostrato che il pluginsdmxregge sul caso stretto, ma resta fragile quando gli endpoint ISTAT si comportano in modo incoerente tra metadata e data.Cosa cambia
agency=IT15xx404, che resta trattato come query/filtro non supportato5xxlato fonte404query non trovataTest
Aggiunti test per:
404non deve attivare fallbackTest eseguiti:
tests/test_sdmx_plugin.pytests/test_ckan_plugin.pytests/test_raw_ext_inference.pytests/test_registry.pyTotale locale:
24 passedNote
Questo PR non introduce caching, backoff sofisticato o failover complesso.
Punta solo a un hardening minimo e difendibile del plugin SDMX contro l'instabilita' degli endpoint ISTAT.